This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Remove resource limits from controller manifest #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 30MB memory limit was quite tight to typical usage: such a limit can cause paging and then get the process OOM-killed. The cpu limit was more reasonable, but without any particular reason to limit this process compared to all the others we run, I think it's simplest to just eliminate the limits. Also remove the same text from manifests in tests to avoid confusion.
bboreham
force-pushed
the
remove-mem-limits
branch
from
e4d5727 to
4a736a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 30MB memory limit was quite tight to typical usage: such a limit can cause paging and then get the process OOM-killed.
The cpu limit was more reasonable, but without any particular reason to limit this process compared to all the others we run, I think it's simplest to just eliminate the limits.
Also remove the same text from manifests in tests to avoid confusion.