Secrets pr preview - user feedback on error #3722
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into secrets-pr-preview
foot
reviewed
Dec 20, 2023
foot
reviewed
Dec 20, 2023
… ListKustomizations to make it easier for user to follow the flow
…ps-enterprise into secrets-pr-preview
… check at parent level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3699
Why was this change made?
Secrets PR Preview creation form wasn't providing the user with feedback if the CTA was clicked and not all required fields had been filled in.
Fixed form validation in External Secret and SOAP and brought it in line with what we're doing in other sections.