Skip to content

Ensure image fully downloaded before display #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ensure image fully downloaded before display #88

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0622f2a
Ignoring photos in cache that aren't fully downloaded yet
ewindso Dec 7, 2017
fa5cb0f
Ensuring valid extension -- if not, use .jpg
ewindso Dec 13, 2017
13ff32b
Removed comments
ewindso Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ export class ImageCache {
private getPath(uri: string, immutable?: boolean): string {
let path = uri.substring(uri.lastIndexOf("/"));
path = path.indexOf("?") === -1 ? path : path.substring(path.lastIndexOf("."), path.indexOf("?"));
const ext = path.indexOf(".") === -1 ? ".jpg" : path.substring(path.indexOf("."));
let ext = path.indexOf(".") === -1 ? ".jpg" : path.substring(path.indexOf("."));
if(['.jpg','.gif','.jpeg','.png'].indexOf(ext.toLowerCase()) == -1) { // ensure it's a valid extension
ext = '.jpg'
}

if (immutable === true) {
return BASE_DIR + "/" + SHA1(uri) + ext;
} else {
Expand Down Expand Up @@ -116,7 +120,7 @@ export class ImageCache {

private get(uri: string) {
const cache = this.cache[uri];
if (cache.path) {
if (cache.path && cache.downloading == false) {
// We check here if IOS didn't delete the cache content
RNFetchBlob.fs.exists(cache.path).then((exists: boolean) => {
if (exists) {
Expand Down