Skip to content

Conversation

@AndrewKostka
Copy link
Contributor

Bug: T394986

Copy link
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the changes this linting applies, I'm happy with most of them. I would vote to change a few things:

  1. headsDownCamelCase instead of snake_case for function names - this should remove a lot of changes
  2. keep function's opening brace ({) on the same line as the function definition
  3. keep a space around the string concatenation operator (.) - I think it makes it look less like a full stop and more like an operator.

@AndrewKostka
Copy link
Contributor Author

Let's use .git-blame-ignore-revs to ignore the resulting squash commit.

@AndrewKostka AndrewKostka marked this pull request as ready for review August 21, 2025 11:39
@AndrewKostka
Copy link
Contributor Author

Copy link
Contributor

@rosalieper rosalieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewKostka AndrewKostka merged commit 8439969 into main Aug 26, 2025
5 checks passed
@AndrewKostka AndrewKostka deleted the add-code-linting branch August 26, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants