Skip to content

Supports fake touch on /dev/input/wl_touch_events #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: lineage-18.1
Choose a base branch
from

Conversation

zccrs
Copy link

@zccrs zccrs commented Apr 2, 2025

persist.waydroid.fake_touch is implemented at a higher level, making it more flexible as it allows enabling fake touch for specific Android applications. However, its implementation may not work for some Android applications (e.g., xuexi_android_10002068.apk).

By implementing fake events in /dev/input/wl_touch_events, it can cover a wider range of cases. Regardless of how the upper-layer Android applications behave, fake events through /dev/input/* will always take effect.

Fixes: waydroid/waydroid#954

@zccrs zccrs force-pushed the lineage-18.1 branch 2 times, most recently from 49f40b2 to 16d9fae Compare April 2, 2025 06:39
persist.waydroid.fake_touch is implemented at a higher level,
making it more flexible as it allows enabling fake touch
for specific Android applications. However, its implementation
may not work for some Android applications (e.g., xuexi_android_10002068.apk).

By implementing fake events in /dev/input/wl_touch_events,
it can cover a wider range of cases. Regardless of how
the upper-layer Android applications behave, fake events
through /dev/input/* will always take effect.

Fixes: waydroid/waydroid#954
@Xephinaiyah
Copy link

Need this for a myriad of children's apps, ABC Mouse for example has issues with tracing the letters of the alphabet, and so on.

@zccrs
Copy link
Author

zccrs commented Apr 22, 2025

Need this for a myriad of children's apps, ABC Mouse for example has issues with tracing the letters of the alphabet, and so on.

Yes, this is a more reliable solution, but its disadvantage is that it cannot be
enabled for specific applications, only for the entire operating system. This
also ensures that it is always effective and useful across all programs.

@aleasto
Copy link
Member

aleasto commented Apr 23, 2025

Thank you for contributing to Waydroid!

However I would prefer not to add this complexity to hwcomposer. I identified the issue with our current approach and I believe I have solved that in waydroid/android_vendor_waydroid@ffe14df

(I couldn't quite verify xuexi_android_10002068.apk because I don't speak mandarin and it seems to require some account)

@zccrs
Copy link
Author

zccrs commented Apr 25, 2025

Thank you for contributing to Waydroid!

However I would prefer not to add this complexity to hwcomposer. I identified the issue with our current approach and I believe I have solved that in waydroid/android_vendor_waydroid@ffe14df

(I couldn't quite verify xuexi_android_10002068.apk because I don't speak mandarin and it seems to require some account)

OK, I can test it.

@Xephinaiyah
Copy link

Example game to test, I updated inside the android OS and I didn't see this one working:
https://www.youtube.com/watch?v=M8dmNdJ1hQM
PBS KIDS Games | Carl the Collector | Marble-ous

It is a drag and drop game with physics.

@aleasto
Copy link
Member

aleasto commented Apr 25, 2025

I updated inside the android OS

Do you mean that you recompiled android yourself to include my patch, or that you updated to the latest official Waydroid images? The patch is only going to be included in tomorrow's builds.

@Xephinaiyah
Copy link

I updated inside the android OS

Do you mean that you recompiled android yourself to include my patch, or that you updated to the latest official Waydroid images? The patch is only going to be included in tomorrow's builds.

The latter. Sounds great, can't wait to update to the patched version! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't click even with fake touch: Ni no Kuni: Cross Worlds, Tower of Fantasy and Wuthering Waves
3 participants