Blockchain updates for L2 extension #1430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickeskov
reviewed
Jun 25, 2024
nickeskov
reviewed
Jun 25, 2024
nickeskov
reviewed
Jun 25, 2024
nickeskov
reviewed
Jun 25, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nickeskov
reviewed
Jul 16, 2024
pkg/state/accounts_data_storage.go
Outdated
| @@ -242,7 +242,7 @@ func (s *accountsDataStorage) entryBytes(addr proto.Address, entryKey string) ([ | |||
| func (s *accountsDataStorage) retrieveEntries(addr proto.Address) ([]proto.DataEntry, error) { | |||
| addrNum, err := s.addrToNum(addr) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, proto.ErrNotFound | |||
There was a problem hiding this comment.
err should be returned and wrapped with proto.ErrNotFound
There was a problem hiding this comment.
Add check errors.Is(err, keyvalue.ErrNotFound)
There was a problem hiding this comment.
Add check errors.Is(err, keyvalue.ErrNotFound) and only then error should be wrapped
nickeskov
reviewed
Jul 16, 2024
nickeskov
added
wip
* Support rollback draft * Moved state to extension * Added cache for retrieving contract values after rollback * Fixed linter issues * Exported functions for mocking * Changed the mock interface * Added a rollback test * Fixed linter issues * Publish the first 100 history entries before start * Added constant keys handling * Fixed rollback check, added needed fields for history entry * Fixed the node blocking while the extension is not ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.