CLI: Code cleanup and small progressbar improvements #5825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mod.rs is long and contains a lot of things. This commit: * splits funcitonality out into submodules (targetrs, runtime.rs, package_source.rs) * Renames the shadowing PackageSource to CliPackageSource to avoid the renamed import and name confusion * Fixes some other small code quality issues (eg Self vs <name> in impls)
theduke
force-pushed
the
cli-progressbar-fix
branch
from
e4b0a16 to
64079c3
Compare
* Use a single progress bar * Show bar again if it was hidden * Remove code duplication for quiet flag handling
The functionality from the is-terminal crate was lifted into the standard library. Since we recently bumped the Rust MSRV, we can now rely on it and remove a dependency.
theduke
force-pushed
the
cli-progressbar-fix
branch
from
64079c3 to
9535733
Compare
|
The progress bar is really neat, I like it! For the future, we might want to integrate detailed bar update for |
marxin
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the CLI
runcommand code a bit by splitting up code into submodules,improving code flow for the progress bar, and replacing the
is-terminalcratewith standard library functionality.
Best reviewed commit by commit.
Dropped:
chore(cli): Only show compilation progress bar after a delay
Because it doesn't work correctly.