Skip to content

Add as_bytes to api Value #5632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Add as_bytes to api Value #5632

wants to merge 29 commits into from

Conversation

@zebreus
Copy link
Contributor

@zebreus zebreus commented Jul 11, 2025

This PR adds a as_bytes and as_bytes_mut function to Value. This change was originally discussed in here in #5598

zebreus added 29 commits July 9, 2025 12:43
@zebreus
Add functions to get a scalar Value as a slice
73f19c4
@zebreus
WIP: second call_dynamic iteration
ef9b2cc
@zebreus
Implement basic register_function functionality in the linker
3567f12
@zebreus
WIP: Add support for registering closures
bac2f04
@zebreus
Reset stack pointer after closure
a41e20b
@zebreus
Add a way to load modules from memory
f77d7b0
@zebreus
Make ModuleLoader borrowing
4284114
@zebreus
Rename ModuleLoader to WasmLoader
53d6883
@zebreus
Rewrite closure_prepare to use dynamic wasm modules
17c1bfb
@zebreus
Allow loading the main module via dlopen
525bab9
@zebreus
Improve wasix closures API
32746ed
@zebreus
Improve error handling
19b2cb9
@zebreus
Stop hijacking call_ctors for closure table init
af6ebab
@zebreus
Use wasm_encoder to build closures instead of string interpolation
ecef418
@zebreus
Clean up closure_prepare
b15ba38
@zebreus
Move WasmValueType into wasix-types
7e06167
@zebreus
Improve access to the indirect function table in the linker
f10760a
@zebreus
Remove comment about allocate_function_table returning a u64
ae5ca3c
@zebreus
Cache the indirect function table export
5eca1e0
@zebreus
Add fixme to closure prepare
785e825
@zebreus
Allow side modules without tls initialization
10823e4
@zebreus
Improve dynamic call tracing
5e9d3e8
@zebreus
Add trace logs for indirect function table operations
e8a55b9
@zebreus
Log dlopen flags
16f96ff
@zebreus
Add more information to call_dynamic traces
8299073
@zebreus
Rename as_bytes
8f828a4
@zebreus
Fix formatting errors
400e05a
@zebreus
Move value as_bytes functions to call_dynamic
75bb9c5
@zebreus
Move changed
adc2812
@zebreus zebreus mentioned this pull request Jul 11, 2025
Merged
@Arshia001
Copy link
Member

@zebreus I think you need to isolate the commit this PR intends to add.

@zebreus
Copy link
Contributor Author

zebreus commented Jul 14, 2025

This is still still a draft, once #5598 is merged and this is rebased, it should be just one commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syrusakbary syrusakbary Awaiting requested review from syrusakbary syrusakbary will be requested when the pull request is marked ready for review syrusakbary is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zebreus @Arshia001