Skip to content

Failure modes #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Failure modes #72

wants to merge 19 commits into from

Conversation

Synicix
Copy link
Contributor

@Synicix Synicix commented Apr 11, 2025

Depends on #70

Summary:

  • Add logs to pod results and corresponding tests
  • Fix issue with command parsing to match docker cli command parsing
  • Add failure handling for launching a pod with a bad command
  • Add failure handling for a pod failing after starting (running failure)
  • Moved some sections of list container to a helper function

Best way to see changes is via:
guzman-raphael/orcapod@snafu...Synicix:orcapod:failure_modes

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 97.56098% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/orchestrator/docker.rs 98.31% 2 Missing ⚠️
src/uniffi/orchestrator/docker.rs 97.26% 2 Missing ⚠️
src/core/error.rs 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Synicix Synicix marked this pull request as ready for review April 22, 2025 23:28
@Synicix
Copy link
Contributor Author

Synicix commented Apr 22, 2025

Updated with new code on dev. Will probably hold up on merging until uffi python stuff is in, since that changes a few things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant