Skip to content

Conversation

@juliandolby
Copy link
Contributor

A non-trivial subset of Python match functionality works

@juliandolby juliandolby requested a review from khatchad as a code owner November 6, 2025 02:57
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.89%. Comparing base (810fe5d) to head (e43ae87).

Files with missing lines Patch % Lines
.../wala/cast/python/ir/PythonCAstToIRTranslator.java 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #342      +/-   ##
============================================
- Coverage     57.91%   57.89%   -0.03%     
- Complexity      624      627       +3     
============================================
  Files           111      111              
  Lines          7671     7692      +21     
  Branches        856      857       +1     
============================================
+ Hits           4443     4453      +10     
- Misses         3050     3061      +11     
  Partials        178      178              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliandolby
Copy link
Contributor Author

Looking at the patch coverage report, I am convinced it is wrong. I put breakpoints in my tests, and watched the 'uncovered' lines get executed and stop at the breakpoints. Also, the system will not work without those lines.

@khatchad
Copy link
Collaborator

khatchad commented Nov 6, 2025

Looking at the patch coverage report, I am convinced it is wrong. I put breakpoints in my tests, and watched the 'uncovered' lines get executed and stop at the breakpoints. Also, the system will not work without those lines.

The coverage report doesn't block merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants