-
Notifications
You must be signed in to change notification settings - Fork 18
Work on match #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Work on match #342
Conversation
… tuple 2) handle first, most trivial case of MatchAs
2) fix to visitCompare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
============================================
- Coverage 57.91% 57.89% -0.03%
- Complexity 624 627 +3
============================================
Files 111 111
Lines 7671 7692 +21
Branches 856 857 +1
============================================
+ Hits 4443 4453 +10
- Misses 3050 3061 +11
Partials 178 178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looking at the patch coverage report, I am convinced it is wrong. I put breakpoints in my tests, and watched the 'uncovered' lines get executed and stop at the breakpoints. Also, the system will not work without those lines. |
The coverage report doesn't block merges. |
A non-trivial subset of Python match functionality works