LevelEdit Public build + replace NvDXTLib. #57
Conversation
OmniBlade
force-pushed
the
refactor/pubed
branch
2 times, most recently
from
3b055ef to
4e1f14c
Compare
| ${crunch_SOURCE_DIR}/crnlib/crn_texture_file_types.cpp | ||
| ${crunch_SOURCE_DIR}/crnlib/crn_threaded_resampler.cpp | ||
| ${crunch_SOURCE_DIR}/crnlib/crn_threading_pthreads.cpp | ||
| $<$<PLATFORM_ID:Windows>:${crunch_SOURCE_DIR}/crnlib/crn_threading_win32.cpp> |
There was a problem hiding this comment.
Q: What's required for crunch to build on Linux/macOS?
There was a problem hiding this comment.
I based it on BinomialLLC/crunch#46 which I am assuming builds on linux as well as windows? The makefile provided just ommits the win32 specific files.
OmniBlade
force-pushed
the
refactor/pubed
branch
from
4e1f14c to
f6ff8c4
Compare
There was a problem hiding this comment.
instead of adding a new .cmake file, should we instead add a (custom) vcpkg build script for this project? since we're using vcpkg already(as part of the FFMPEG PR). Mixing both vcpkg and the FetchContent doesn't seem like a great idea.
There was a problem hiding this comment.
Wouldn't that require vcpkg on all platforms then? I'd rather rely on platforms package management systems where possible and give developers the ability to use alternative methods for providing required dependencies rather than making vcpkg a hard requirement. The other option is to vendor it into our source tree.
There was a problem hiding this comment.
Vcpkg is cross-platform(I've never used it on Linux though), so that shouldn't be an issue. The (potential) problem that I see with using the platform package management is that the platform may not have the correct version of a dependency, so you might need to build dependencies anyway. At least with vcpkg we can also package up prebuilt dependencies so that you don't need to build everything all the time.
From my (somewhat limited) use of vcpkg, it should be optional - unless you explicitly tell cmake to use the packages from vcpkg, it will look on your system.
There was a problem hiding this comment.
Fair point. Could do a find call and fall back to fetching and building if its not found I guess?
OmniBlade
force-pushed
the
refactor/pubed
branch
from
f6ff8c4 to
3a773d0
Compare
Replaces NvDXTLib with crunch to allow open source DXT texture compression. Builds editor as "Public" build. This disabled a bunch of VSS code that doesn't work outside of the original development environment.
OmniBlade
force-pushed
the
refactor/pubed
branch
from
3a773d0 to
542a723
Compare
3 participants
Replaces NvDXTLib with crunch to allow open source DXT texture compression.
Builds the editor as a "Public" build. This disables a bunch of VSS code that doesn't work outside of the original development environment.