Skip to content

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Jul 7, 2025

Specification for emulation.setUserAgentOverride command.


Preview | Diff

@sadym-chromium sadym-chromium force-pushed the sadym/emulation.setUserAgentOverride branch from e22449c to 989153d Compare July 7, 2025 16:04
@sadym-chromium
Copy link
Contributor Author

@OrKoN @juliandescottes please take a look

@sadym-chromium
Copy link
Contributor Author

@juliandescottes please take a look

@sadym-chromium
Copy link
Contributor Author

@juliandescottes @whimboo PTAL

Copy link
Contributor

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sadym-chromium ! Overall that looks fine to me. Just some nits and suggestions. Before approving I just want to check the reason why we attach this to the session rather than to the remote end. Back to you

@sadym-chromium sadym-chromium force-pushed the sadym/emulation.setUserAgentOverride branch 2 times, most recently from b9c9a42 to 017d873 Compare August 28, 2025 14:30
@sadym-chromium
Copy link
Contributor Author

@juliandescottes PTAL I believe I addressed your comments, thanks!

Copy link
Contributor

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't notice that the context/contexts error was also in the other commands. Thanks for fixing them as well. Looks good to me now!

@sadym-chromium sadym-chromium force-pushed the sadym/emulation.setUserAgentOverride branch from 4737cc2 to 4e6ff98 Compare September 10, 2025 11:39
@sadym-chromium sadym-chromium force-pushed the sadym/emulation.setUserAgentOverride branch from 4e6ff98 to 40c6c16 Compare September 10, 2025 11:51
@sadym-chromium sadym-chromium merged commit bd3a7f6 into main Sep 10, 2025
5 checks passed
@sadym-chromium sadym-chromium deleted the sadym/emulation.setUserAgentOverride branch September 10, 2025 11:59
github-actions bot added a commit that referenced this pull request Sep 10, 2025
SHA: bd3a7f6
Reason: push, by sadym-chromium

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants