Set selector syntax to selector name when possible #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax of selectors is often not formally defined in specs. For selectors that are function-like such as `:nth-child()`, we'll have to see how specs can be updated. For selectors are are keyword-like such as `:visited`, updating the specs seems more confusing than anything else though: the syntax of the selector goes without saying, it is simply the selector's name. This update makes Reffy set the selector's syntax to be the selector's name when the selector is keyword-like.
dontcallmedom
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax of selectors is often not formally defined in specs. For selectors that are function-like such as
:nth-child(), we'll have to see how specs can be updated. For selectors are are keyword-like such as:visited, updating the specs seems more confusing than anything else though: the syntax of the selector goes without saying, it is simply the selector's name.This update makes Reffy set the selector's syntax to be the selector's name when the selector is keyword-like.