fix: can't access property "size", store._customProperties is undefined

[TimvdEijnden]

When using Pinia module in the Vue dev tools in Firefox (Zen browser) and I select a store the following error occurs, it is fixed by checking if store._customProperties exists.

When I set a breakpoint and set store._customProperties to a new Map() it seems to work.

[netlify]

✅ Deploy Preview for pinia-official canceled.

Name	Link
🔨 Latest commit	627de5c
🔍 Latest deploy log	https://app.netlify.com/projects/pinia-official/deploys/687646277d2fb300089caa4d

[posva]

do you have a repro?

[TimvdEijnden]

I can reproduce it on https://www.jumbo.com but I can try create a separate one if really needed

[posva]

Yes, please, a repro must be minimal

[TimvdEijnden]

Here it is the repro: https://stackblitz.com/edit/nuxt-pinia-customproperties-undefined?file=app.vue

[posva]

thanks! That's quite weird, I suppose it goes away if you use the nuxt devtools?
Regarding the PR, this shouldn't be the fix as the _customProperties should always be defined, so if you want to push this forward, you will need to dig a bit deeper into the problem. Thanks!

[TimvdEijnden]

Here you see the _customProperties only added in case __DEV__ || (__USE_DEVTOOLS__ && IS_CLIENT) and that is false in this scenario.

const store: Store<Id, S, G, A> = reactive(
    __DEV__ || (__USE_DEVTOOLS__ && IS_CLIENT)
      ? assign(
          {
            _hmrPayload,
            _customProperties: markRaw(new Set<string>()), // devtools custom properties
          },
          partialStore
          // must be added later
          // setupStore
        )
      : partialStore
  ) as unknown as Store<Id, S, G, A>

I only wanted to get rid of the error, not sure what the best best appoach is to fix it since the app is running production mode.