chore(storybook): makes main.js follow Common JS syntax, which allows it to be run with node-23.8 #2100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it to be run with node-23.8 main.js mixed Common JS and ESM syntax, which prevented pnpm dev:storybook from working in (at least) node 23.7 and 23.8. Storybook breaks in newer versions of Node.js #2083
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main.js mixed Common JS and ESM syntax, which prevented
pnpm dev:storybookfrom working in (at least) node 23.7 and 23.8.Storybook breaks in newer versions of Node.js #2083
Summary
This file caused some headaches after i formatted my computer and installed the latest version of node, which was supposed to work with shoreline, only to find that storybook randomly wouldn't run anymore.
Example