feat: Create Global Sections Settings tab #2845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
lariciamota
changed the title
lariciamota
requested review from
gabpaladino,
renatomaurovtex,
lucasfp13 and
beatrizmilhomem
and removed request for
a team,
gabpaladino and
renatomaurovtex
beatrizmilhomem
requested changes
May 15, 2025
beatrizmilhomem
approved these changes
May 16, 2025
lucasfp13
reviewed
May 16, 2025
Comment on lines
43
to
46
| const context = usePage<SearchPageContext | PLPContext>() | ||
| const globalDeliverySettingsData = | ||
| context?.globalSectionsSettings?.regionalization?.deliverySettings ?? {} | ||
| const cmsData = deepmerge(globalDeliverySettingsData, deliverySettings ?? {}) |
There was a problem hiding this comment.
Will we need this deep merge in every component that will use this global settings? If so, maybe move this logic to a separated function?
There was a problem hiding this comment.
Great suggestion! Since it'll be used exactly like that in FilterSlider, I've extracted it to a utils file
lucasfp13
approved these changes
May 16, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
It creates a new tab inside the Global Sections CMS. In the new Settings tab, it will be possible to configure settings related to regionalization, which will be used by components such as the Region Modal and Region Popover.
This PR doesn't update all components/sections, it'll be done after. In this PR, there is an update to
FilterDesktopso we can validate the change.How it works?
The merchant will be able to configure their regionalization-related message in a single place (Global Sections Settings tab) instead of duplicate messages through sections.
To avoid introducing breaking changes, I haven't removed the messages from the sections yet - this will be done in v4. I've added a deprecation notice in every field that was created in the Settings tab.
In v3, the components/sections will use the messages defined in the sections CMS; if they're blank, they will use the messages in the Global Sections Settings tab.
How to test it?
In the CMS of the vendemo store, I've added messages in the Global Sections Settings tab using a
[GS]at the beginning of every message so we can identify the ones that are coming from this tab.PLP
I've only removed (left blank) the messages in
Product List Page > Product Gallery > Filter > Delivery Settings > **Delivery Section description**andProduct List Page > Product Gallery > Filter > Delivery Settings > Delivery Custom labels > **Shipping label**, those are the ones that should use the GS one.Search page
The messages from
Search Page > Product Gallery > Filter > Delivery Settingswere all left blank (we hadn't updated this page to add the messages -- so this page didn't have messages defined for those cases, and we hadn't noticed 😣).Starters Deploy Preview
References