chore: on ci added script to set resolution on starter project before… #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ommeirelles
requested review from
hellofanny and
eduardoformiga
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
matheusps
reviewed
May 13, 2025
lucasfp13
approved these changes
May 14, 2025
Co-authored-by: Lucas Feijó <[email protected]>
matheusps
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… install
What's the purpose of this pull request?
Prevent yarn of install a version of @faststore deps from registry on the CI.
How it works?
Created a script to add a resolution property on the package.json to make the yarn resolve all @faststore deps to resolve to the root version (the one generated on the build instead of the registry)
How to test it?
Creating a PR that add something to the @faststore/component or UI and use it on the @faststore/core. This would make the CI fail saying the property does not exists in the @faststore/component or UI cause it would install in the @faststore/core deps from @faststore/ui or @faststore/component from the registry instead the new one generated on the PR.
Starters Deploy Preview
References
SFS-2505
Checklist
You may erase this after checking them all 😉
PR Title and Commit Messages
feat,fix,chore,docs,style,refactor,ciandtestPR Description
breaking change,bug,contributing,performance,documentation..Dependencies
pnpm-lock.yamlfile when there were changes to the packagesDocumentation
@Mariana-Caetanoto review and update (Or submit a doc request)