Skip to content

feat: fs x #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: fs x #2795

wants to merge 10 commits into from

Conversation

matheusps
Copy link
Contributor

@matheusps matheusps commented Apr 17, 2025

[WIP]

Changeset:

  • Next 15 update
  • React 19 update
  • App router update
  • Configure third party scripts using Next Script
  • Use Next font
  • FS Router module
  • Server side RenderSections

@matheusps matheusps added the don't merge Blocked by some reason - - Please mention the reason label Apr 17, 2025
@matheusps matheusps self-assigned this Apr 17, 2025
@matheusps matheusps requested a review from a team as a code owner April 17, 2025 12:36
@matheusps matheusps requested review from hellofanny and eduardoformiga and removed request for a team April 17, 2025 12:36
Copy link

codesandbox-ci bot commented Apr 17, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Comment on lines 20 to 25
return NextResponse.json({
status: 200,
revalidated: false,
now: Date.now(),
message: 'Missing path to revalidate',
})
Copy link

@semgrep-code-vtex-org semgrep-code-vtex-org bot Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: Affected versions of next are vulnerable to Improper Authorization. Improper authorization handling in Next.js applications enables attackers to bypass security controls for paths directly under the application's root directory, potentially exposing sensitive data or functionality. This issue affects versions prior to Next.js 14.2.15, where authorization logic based solely on pathname fails to account for certain direct page accesses.

Manual Review Advice: A vulnerability from this advisory is reachable if you use authorization to protect a page directly under the application's root directory (for example, https://example.com/foo) and you do NOT host your application on Vercel

Fix: Upgrade this library to at least version 14.2.15 at faststore/pnpm-lock.yaml:7944.

Reference(s): GHSA-7gfc-8cq8-jh5f, CVE-2024-51479

🎈 Fixed in commit 67906b0 🎈


revalidatePath(path, 'page')

return NextResponse.json({ status: 200, revalidated: true, now: Date.now() })
Copy link

@semgrep-code-vtex-org semgrep-code-vtex-org bot Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: Affected versions of next are vulnerable to Improper Authorization. Next.js middleware-based authorization checks can be bypassed by an attacker who forges external requests that include a specific header, tricking the application into treating the request as a trusted internal call and thus bypassing access controls.

Manual Review Advice: A vulnerability from this advisory is reachable if you perform authorization in the middleware

Fix: Upgrade this library to at least version 15.2.3 at faststore/pnpm-lock.yaml:7843.

Reference(s): GHSA-f82v-jwr5-mffw, CVE-2025-29927

🎉 Removed in commit 3f17bfb 🎉

Comment on lines 20 to 25
return NextResponse.json({
status: 200,
revalidated: false,
now: Date.now(),
message: 'Missing path to revalidate',
})
Copy link

@semgrep-code-vtex-org semgrep-code-vtex-org bot Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: Affected versions of next are vulnerable to Improper Authorization. Next.js middleware-based authorization checks can be bypassed by an attacker who forges external requests that include a specific header, tricking the application into treating the request as a trusted internal call and thus bypassing access controls.

Manual Review Advice: A vulnerability from this advisory is reachable if you perform authorization in the middleware

Fix: Upgrade this library to at least version 15.2.3 at faststore/pnpm-lock.yaml:7843.

Reference(s): GHSA-f82v-jwr5-mffw, CVE-2025-29927

🧼 Removed in commit 3f17bfb 🧼


revalidatePath(path, 'page')

return NextResponse.json({ status: 200, revalidated: true, now: Date.now() })
Copy link

@semgrep-code-vtex-org semgrep-code-vtex-org bot Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: Affected versions of next are vulnerable to Improper Authorization. Improper authorization handling in Next.js applications enables attackers to bypass security controls for paths directly under the application's root directory, potentially exposing sensitive data or functionality. This issue affects versions prior to Next.js 14.2.15, where authorization logic based solely on pathname fails to account for certain direct page accesses.

Manual Review Advice: A vulnerability from this advisory is reachable if you use authorization to protect a page directly under the application's root directory (for example, https://example.com/foo) and you do NOT host your application on Vercel

Fix: Upgrade this library to at least version 14.2.15 at faststore/pnpm-lock.yaml:7944.

Reference(s): GHSA-7gfc-8cq8-jh5f, CVE-2024-51479

Fixed in commit 67906b0

@matheusps matheusps changed the title [WIP] FS X feat: fs x Apr 29, 2025
Comment on lines +19 to +24
return NextResponse.json({
status: 200,
revalidated: true,
now: Date.now(),
message: `Revalidated path: ${path}`,
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: Affected versions of next are vulnerable to Improper Authorization. Next.js middleware-based authorization checks can be bypassed by an attacker who forges external requests that include a specific header, tricking the application into treating the request as a trusted internal call and thus bypassing access controls.

Manual Review Advice: A vulnerability from this advisory is reachable if you perform authorization in the middleware

Fix: Upgrade this library to at least version 15.2.3 at faststore/pnpm-lock.yaml:7843.

Reference(s): GHSA-f82v-jwr5-mffw, CVE-2025-29927

💬 To ignore this, reply with:
/fp <comment> for false positive
/ar <comment> for acceptable risk
/other <comment> for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by ssc-91c0a03f-a79a-4539-915f-c718686fa6b7.

Comment on lines +9 to +14
return NextResponse.json({
status: 200,
revalidated: false,
now: Date.now(),
message: 'Missing path to revalidate',
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: Affected versions of next are vulnerable to Improper Authorization. Next.js middleware-based authorization checks can be bypassed by an attacker who forges external requests that include a specific header, tricking the application into treating the request as a trusted internal call and thus bypassing access controls.

Manual Review Advice: A vulnerability from this advisory is reachable if you perform authorization in the middleware

Fix: Upgrade this library to at least version 15.2.3 at faststore/pnpm-lock.yaml:7843.

Reference(s): GHSA-f82v-jwr5-mffw, CVE-2025-29927

💬 To ignore this, reply with:
/fp <comment> for false positive
/ar <comment> for acceptable risk
/other <comment> for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by ssc-91c0a03f-a79a-4539-915f-c718686fa6b7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Blocked by some reason - - Please mention the reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant