chore: Handle B2B users scenario #2760
Draft
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfp13
requested review from
hellofanny and
renatamottam
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
lariciamota
reviewed
Apr 2, 2025
lariciamota
force-pushed
the
feat/delivery-promise
branch
from
a28d534 to
8fbe4f1
Compare
3 tasks
|
@lucasfp13 this PR is blocked for now right? Can we convert to |
lariciamota
force-pushed
the
feat/delivery-promise
branch
from
8805012 to
c540749
Compare
lariciamota
force-pushed
the
feat/delivery-promise
branch
from
c540749 to
b0aa3d3
Compare
lariciamota
force-pushed
the
feat/delivery-promise
branch
2 times, most recently
from
789c99a to
b41c2a9
Compare
This PR intends to ensure all location data (`postalCode`, `geoCoordinates` and `country`) is being synchronized when needed. It updates geo coordinates when users set a postal code and ensure location data won't be overwritten if users grant geo location consent late. - Enable Delivery Promise on discovery.config; - Open the localhost store on anon tab (to ensure no stale data); - First, consent geo location data from popup and look to the IDB `fs::session` value, it should fill `geoCoordinates` data after `useGeolocation` hook execution; - Then try to set a postal code, the `postalCode` should be set and `geoCoordinates` should be different now (based on the postal code); - Another test: open another anon tab and, while the popup asking for geo location consent set a postal code. Then, after the session is updated with the new location (based on the postal code), grant the geo location consent and nothing should happen since user have already set the postal code. vtex-sites/starter.store#734 --------- Co-authored-by: Fanny Chien <[email protected]> Co-authored-by: Larícia Mota <[email protected]>
lucasfp13
force-pushed
the
chore/b2b-saved-addresses
branch
from
87107af to
cdb12e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR intends to check for
customerIdwhen a user is related to a B2B org.How to test it?
b2bfaststoredevand run the server;customerIdvalue.Starters Deploy Preview