Skip to content

fix: order used in props overriding of slots and extensions points #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gsbenevides2
Copy link

What does this PR do? *

A ordem das props usadas em composições com o Blocks e Slots era a de:

  • Primeiro as que vinham ser sobrescritas pela customização.
  • Depois as que vem por padráo no tema da loja, que no caso envolve as props que possuem valores default.

Isso fazia que caso uma customização não conseguisse sobrescrever uma prop com um valor padrão como o text do rich-text. Limitando o uso de blocks e slots.

Minha sugestão visa inverter a orde onde as props do tema da loja vem por primeiro e as customizações sáo aplicadas em cima do tema da loja.

Copy link
Contributor

vtex-io-ci-cd bot commented Mar 9, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant