Skip to content

Conversation

@McHauge
Copy link

@McHauge McHauge commented Jul 23, 2025

Try to remove duplicate type names for 'Platform' and 'Tag' based on my findings using the full file available here: https://vrchat.community/openapi.yaml

Not entirely sure how this file gets assembled, soI have tried to do it as close to what I saw used in other places in the duplicate files

Closes #482

Try and remove duplicate type names for 'Platform' and 'Tag' based on my findings using the full file avaliable here: https://vrchat.community/openapi.yaml

Not fully sure how this file gets assembled so have tried to do it as close to what I saw used other places in the same files

vrchatapi#482
@ariesclark ariesclark enabled auto-merge (squash) July 23, 2025 23:20
format: binary
description: The binary blob of the png file.
tag:
type: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't consider this the same tag, it is an explicit union of:

  • icon, gallery, sticker, emoji, or emojianimated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, that one makes sense. I don't think that one is one of the ones that gave errors now that I look at it again. Feel free to not include that one.

@McHauge
Copy link
Author

McHauge commented Jul 24, 2025

I have since I made this one also found a couple of missing type definitions. Where the names have been left out, and not being defined in the schema, only local in the one message with out a name for the overall type.

is that something I should add here or would that work better in a separate ticket/pr?

Thsese 3 Schema definitions seems to be missing (and then they will need referencing to their messages):

    PlatformHistory:
      title: PlatformHistory
      description: Platform History
      type: object
      properties:
        isMobile:
          type: boolean
        platform:
          type: string
        recorded:
          type: string
          format: date-time

    PublishedListing:
      title: PublishedListing
      description: Published Listing
      type: object
      properties:
        description:
          type: string
        displayName:
          type: string
        imageId:
          type: string
        listingId:
          type: string
        listingType:
          type: string
        priceTokens:
          type: integer

    Otp:
      title: Otp
      description: Otp
      type: object
      required:
        - code
        - used
      properties:
        code:
          type: string
        used:
          type: boolean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate typename 'Platform' and 'Tag', breaking OpenAPI -> Go generatators

2 participants