Remove Description from NetDev and add friendly_name #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description is not a supported field from systemd netdev (https://www.freedesktop.org/software/systemd/man/latest/systemd.netdev.html\#%5BWireGuardPeer%5D%20Section%20Options). friendly_name makes the Wireguard config compatible with prometheus_wireguard_exporter Fix voxpupuli#127 Fix voxpupuli#123
fetzerms
requested changes
Mar 15, 2025
|
|
||
| [WireGuardPeer] | ||
| <% if $peer['description'] { -%> | ||
| Description=<%= $peer['description'] %> |
There was a problem hiding this comment.
Removing description for peers looks good to me, but it might actually be useful to keep including it as comments (so it can be seen when looking at the config file).
| [Peer] | ||
| <% if $peer['description'] { -%> | ||
| # <%= $peer['description'] %> | ||
| # friendly_name = <%= $peer['description'] %> |
There was a problem hiding this comment.
I like the idea of building compatibility for the prometheus exporter. Is friendly_name documented somewhere?
| <% if $peer['description'] { -%> | ||
| # <%= $peer['description'] %> | ||
| # friendly_name = <%= $peer['description'] %> | ||
| Description= |
There was a problem hiding this comment.
I don't think Description is a valid field in wireguard configuration files, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description is not a supported field from systemd netdev (https://www.freedesktop.org/software/systemd/man/latest/systemd.netdev.html\#%5BWireGuardPeer%5D%20Section%20Options). friendly_name makes the Wireguard config compatible with prometheus_wireguard_exporter
Fix #127
Fix #123
Pull Request (PR) description
This Pull Request (PR) fixes the following issues