If the peer name in the facts is not the same as in the configuration #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the peer name in the facts is not the same as in the configuration:
#gluster peer status --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
.........
<peerStatus>
<peer>
.........
<hostname>192.168.0.10</hostname>
<hostnames>
<hostname>192.68.0.10</hostname>
<hostname>gst03</hostname>
</hostnames>
..........
</peer>
<peer>
.........
<hostname>gst02</hostname>
<hostnames>
<hostname>gst02</hostname>
</hostnames>
.........
</peer>
</peerStatus>
</cliOutput>
Then the gluster_peer_list fact will contain the following line:
192.168.0.10,gst02
and due to the fact that the configuration says gst03 and not IP, the following will always be executed:
Notice: /Stage[main]/myclass /Gluster::Peer[gst03]/Exec[gluster peer probe gst03]/returns: executed successfully (corrective)
My edit takes all names from peers /cliOutput/peerStatus/peer/hostnames/hostname
the fact string will be:
192.168.0.10,gst03,gst02
and then in line 52 of the manifests/peer.pp file it will find the value.
After this, the command "gluster peer probe gst03" will not be executed every time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
If the peer name in the facts is not the same as in the configuration: #gluster peer status --xml
Then the
gluster_peer_listfact will contain the following line:192.168.0.10,gst02and due to the fact that the configuration says gst03 and not IP, the following will always be executed: Notice:
/Stage[main]/myclass /Gluster::Peer[gst03]/Exec[gluster peer probe gst03]/returns: executed successfully (corrective)My edit takes all names from peers /cliOutput/peerStatus/peer/hostnames/hostname the fact string will be:
192.168.0.10,gst03,gst02and then in line 52 of the manifests/peer.pp file it will find the value. After this, the command
gluster peer probe gst03will not be executed every timeThis Pull Request (PR) fixes the following issues