[apt] fix: actually use the version specified #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the usage of versions later then 3.12 as the incorrect apt repository was being specified.
3.12 has a major memory leak that has been corrected in 3.13, use it as the default instead. Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1613512
dhoppe
reviewed
Dec 3, 2018
manifests/repo/apt.pp
Outdated
| default => false, | ||
| } | ||
| if versioncmp($release, '3.12') < 0 { | ||
| $repo_url = "http://download.gluster.org/pub/gluster/glusterfs/${release}/LATEST/Debian/${::lsbdistcodename}/apt/" |
There was a problem hiding this comment.
@gnif Why did you changed the variable? It does only contain the version, but the spec tests are running against a specific release.
There was a problem hiding this comment.
Because the URL is incorrect. This doesn't break the specific release the spec tests are running against as it will still select the correct version.
|
This now needs a rebase, but you are correct that this is needed. |
|
@gnif Could please do a rebase? This pull request is tested against old versions of Puppet. For example, we dropped support for Puppet 4 two months ago. |
|
Thank you very much for your contribution, but I will close this pull request in favour of #203. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the usage of versions later then 3.12 as the incorrect apt repository was being specified.