pass 'release' attribute to sub classes #116
Conversation
prior to this this commit 'release' atribute from 'main' class wasn't passed to sub-classes construct '! defined Class' provides random results, parser dependable and shouldn't be used
|
Hi @vchepkov, thanks for the PR. Can you add spec tests for your change? Join us in our IRC channel #voxpupuli on freenode if you've any questions about testing. |
|
I am pretty much inept, when it comes to tests, if you point me to an example, I can try to make something up, but in my defense, it seems tests didn't much helped here, 'release' attribute to the class wasn't used anywhere |
|
Dear @vchepkov, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @vchepkov, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
3 participants
prior to this this commit 'release' atribute from 'main' class wasn't passed to sub-classes
construct '! defined Class' provides random results, parser dependable and shouldn't be used