Skip to content

Conversation

HollowMan6
Copy link
Collaborator

@HollowMan6 HollowMan6 commented Oct 18, 2025

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Resolves #2234

Also support not setting the seed value (null)

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a data.seed configuration option to ensure reproducible data shuffling, which is a good improvement for experiment consistency. The changes are applied across various configuration files and documentation. However, there are a couple of important issues. First, two auto-generated configuration files have been modified manually, which violates the repository's process. These should be updated by running the generation script after changing the source configs. Second, the implementation does not handle the case where data.seed is set to null, which will lead to a runtime crash. The documentation should be updated to warn users about this, and ideally, the code should be made more robust.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a data.seed configuration option to control the seed for data shuffling, which is a useful feature for reproducibility. The implementation correctly handles cases where the seed is provided as an integer or is explicitly set to null (or omitted), allowing for both deterministic and non-deterministic shuffling. However, there is a critical issue in the documentation that needs to be addressed.

Also support not setting the seed value (null)

Signed-off-by: Hollow Man <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully introduces the data.seed configuration option to enable reproducible data shuffling, which is a valuable addition for experiment consistency. The changes are applied consistently across various configuration files, documentation, and trainer implementations. My review includes a few suggestions to enhance robustness by adding type validation for the new seed parameter, which will help prevent runtime errors from invalid configurations.

@vermouth1992 vermouth1992 merged commit 65eb019 into volcengine:main Oct 20, 2025
45 of 47 checks passed
@HollowMan6 HollowMan6 deleted the seed branch October 20, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

在ppo_trainer.yaml文件中,没有提供data.seed这个选项

2 participants