Skip to content

fix Ray runtime env no working dir issue #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix Ray runtime env no working dir issue #3673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions verl/trainer/constants_ppo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,26 @@ def get_ppo_ray_runtime_env():
A filter function to return the PPO Ray runtime environment.
To avoid repeat of some environment variables that are already set.
"""
working_dir = (
json.loads(os.environ.get(RAY_JOB_CONFIG_JSON_ENV_VAR, "{}")).get("runtime_env", {}).get("working_dir", None)
)

runtime_env = {
"env_vars": PPO_RAY_RUNTIME_ENV["env_vars"].copy(),
**({"working_dir": None} if working_dir is None else {}),
}
for key in list(runtime_env["env_vars"].keys()):
job_cfg_raw = os.environ.get(RAY_JOB_CONFIG_JSON_ENV_VAR, "{}")
try:
job_cfg = json.loads(job_cfg_raw)
except Exception:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

It's a good practice to catch specific exceptions rather than the generic Exception. This prevents masking other unexpected errors and makes the code more robust. In this case, json.loads will raise a json.JSONDecodeError if the string is not valid JSON.

Suggested change
except Exception:
except json.JSONDecodeError:

job_cfg = {}

working_dir = None
if isinstance(job_cfg, dict):
working_dir = job_cfg.get("runtime_env", {}).get("working_dir")

runtime_env = {"env_vars": PPO_RAY_RUNTIME_ENV["env_vars"].copy()}

# Only pass through working_dir if one already exists; otherwise omit.
if working_dir is not None:
runtime_env["working_dir"] = working_dir

# Avoid duplicating env vars that are already set in the driver/job env.
env = runtime_env["env_vars"]
for key in list(env.keys()):
if os.environ.get(key) is not None:
runtime_env["env_vars"].pop(key, None)
return runtime_env
env.pop(key, None)

return runtime_env
Loading