🐛Move volumecheck below ReconfigureVM #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubronzhan
force-pushed
the
topic/lubron/move_virtual_controller
branch
2 times, most recently
from
9f28778 to
12c86b9
Compare
github-actions
bot
added
size/L
lubronzhan
force-pushed
the
topic/lubron/move_virtual_controller
branch
2 times, most recently
from
8d231ac to
4ccd360
Compare
lubronzhan
changed the title
faisalabujabal
approved these changes
Oct 24, 2025
lubronzhan
force-pushed
the
topic/lubron/move_virtual_controller
branch
from
4ccd360 to
60d47ae
Compare
abaruni
reviewed
Oct 24, 2025
abaruni
approved these changes
Oct 24, 2025
lubronzhan
force-pushed
the
topic/lubron/move_virtual_controller
branch
from
60d47ae to
5dd47a9
Compare
akutz
requested changes
Oct 24, 2025
lubronzhan
force-pushed
the
topic/lubron/move_virtual_controller
branch
4 times, most recently
from
f531a50 to
1263b42
Compare
lubronzhan
force-pushed
the
topic/lubron/move_virtual_controller
branch
from
1263b42 to
1ef41dd
Compare
Minimum allowed line rate is |
akutz
approved these changes
Oct 27, 2025
bryanv
reviewed
Oct 27, 2025
| Message: "cannot add/edit/remove controllers when the VM is powered on", | ||
| } | ||
| if moVM.Runtime.PowerState != vimtypes.VirtualMachinePowerStatePoweredOff { | ||
| // This shouldn't happen since validating webhook should've blocked this. |
There was a problem hiding this comment.
FWIW this could happen b/c we can't know the VM's actual power state in the webhook
There was a problem hiding this comment.
Then do you think it's more appropriate to error and emit a condition on VM?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Right now order between volume check and reconciling virtual controllers is incorrect. Adding virtualcontrollers need to happen before volume check.
So
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: