- 
                Notifications
    You must be signed in to change notification settings 
- Fork 59
🌱 Improve build/test times in Github actions #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            akutz
  wants to merge
  1
  commit into
  vmware-tanzu:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
akutz:feature/go-test-cache
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    be70d9b    to
    60a63e0      
    Compare
  
    This patch seeks to improve the amount of time required to build/test this project when run via Github actions. This change: * Disables the setup-go action's native caching mechanism * Introduces two, explicit caching actions for caching the Go build/test cache and Go mod cache directories separately because the Go build/test cache should be cached whenever the sources change. However, the Go mod cache should only be cached whenever the module definitions change. * Resets the mtime of checked out Go sources based on a file's calculated hash due to the way Go's test caching algoritm works via golang/go#58571.
60a63e0    to
    468b1d7      
    Compare
  
    | 
 Minimum allowed line rate is  | 
              
                    lubronzhan
  
              
              approved these changes
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Interesting.
Just curious is the target "restore" accurate enough considering how the cli works. Maybe a comment on the Makefile target would be easier for the reader to understand?
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What does this PR do, and why is it needed?
This patch seeks to improve the amount of time required to build/test this project when run via Github actions. This change:
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: