🌱 Encrypt disks on copy for fast deploy direct #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/enc-on-copy-fd-direct-mode
branch
5 times, most recently
from
75f164b to
b6833f1
Compare
This patch updates Fast Deploy's direct mode to encrypt disks as part of the copy operation instead of after the fact.
akutz
force-pushed
the
feature/enc-on-copy-fd-direct-mode
branch
from
b6833f1 to
14750bc
Compare
Minimum allowed line rate is |
lubronzhan
reviewed
Sep 26, 2025
|
|
||
| // Copy the disks using the same crypto key as the VM if the storage | ||
| // class is encrypted. | ||
| if isEncryptedStorageProfile && configSpec.Crypto != nil { |
There was a problem hiding this comment.
Looks like configSpec.Crypto doesn't have to be not nil, if ds.Backing.Crypto is not nil?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch updates Fast Deploy's direct mode to encrypt disks as part of the copy operation instead of after the fact.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: