Skip to content

🌱 Refactor bootstrap templates #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🌱 Refactor bootstrap templates #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f6cc62
Refactor bootstrap_template.go to use generics
akutz Aug 15, 2025
79cb992
Refactor bootstrap template to return err
akutz Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/providers/vsphere/vmlifecycle/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type BootstrapData struct {
Sysprep *sysprep.SecretData
}

type TemplateRenderFunc func(string, string) string
type TemplateRenderFunc func(string, string) (string, error)

type BootstrapArgs struct {
BootstrapData
Expand Down
6 changes: 5 additions & 1 deletion pkg/providers/vsphere/vmlifecycle/bootstrap_sysprep.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ func BootstrapSysPrep(
}

if bsArgs.TemplateRenderFn != nil {
data = bsArgs.TemplateRenderFn(key, data)
var err error
data, err = bsArgs.TemplateRenderFn(key, data)
if err != nil {
return nil, nil, fmt.Errorf("failed to render template for key %q: %w", key, err)
}
}

identity = &vimtypes.CustomizationSysprepText{
Expand Down
Loading