Correctly apply nearby aggro on start opening "Treasure" gameobjects with the correct lockId #2997
+236
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should use both faction AND lockId checks
|
The indentation looks totally whack. |
|
Looked fine on the file itself. I'll try and adjust it |
adjust indentation
|
Currently has an issue with handling factions 101 and 102 since the objects are openable by the object faction's friendly mask and should aggro based on the faction's hostile mask. |
Updated AnyUnfriendlyUnitInObjectRangeCheck to take WorldObject faction input, used this to fix bug relating to specific faction aggro on gameobjects
Fixed now. Should be good to go. |
Use ToUnit instead of static cast without crash handling
How I missed this is beyond me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Correctly applies aggro effect on opening spell start and only on gameobjects it's supposed to according to testing.
Corrects usage of factions 94, 101, 102, 114, and 1375 per sniffs.
Constructor overloading AnyUnfriendlyUnitInObjectRangeCheck so that it can take a WorldObject as a faction input.
Proof
From testing:
Opening an object will only cause the aggro effect if it uses lockId 57 (for open objects) or a lockId that requires lockpicking to open.
Further, the object must use a faction template that uses faction 77 ("Treasure"). Otherwise the aggro effect does not trigger. (These faction template IDs are 94, 100 (unused), 101, 102, 114, and 1375)
Results from testing on Classic 1.15 (can supply videos on request, forgot to film the objects that didn't cause aggro):
Opening an object with correct lockId but without a "Treasure" faction, e.g. Cat Figurine (Faction 0, lockId 57) or Venture Co. Engineering Plans (Faction 84 - Alliance Generic, lockId 57) does not aggro nearby mobs.
Opening an object with correct faction but incorrect lockId, e.g. Food Crate (Faction 94, lockId 43) does not aggro nearby mobs.
Opening any object with faction 94 and lockId 57 results in aggro:
https://i.imgur.com/wDSV9do.mp4
https://i.imgur.com/eLaEJCB.mp4
Issues
How2Test
Todo / Checklist