feat: update agent lookup to use query parameters #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert agent lookup endpoint to use query parameters
Summary
This PR converts the GET
/v1/agent/lookup
endpoint from using request body parameters to query parameters, along with updating the Python SDK to match. This addresses the inconsistency where a GET endpoint was requiring a request body, which is not RESTful best practice.Changes made:
lookup_agent
functions in both main and local execution routes to acceptname
,version
, andid
as FastAPI Query parameters instead of anAgentLookupRequest
bodyagent.get()
method to send parameters via theparams
argument instead ofdata
(request body)id
orname
can be provided)AgentInfoResponse
Review & Testing Checklist for Human
/v1/agent/lookup
endpoint with both lookup methods (byid
and byname
+version
) to ensure it works correctly with query parametersid
andname
provided)Recommended test plan:
Diagram
Notes
AgentLookupRequest
model in the backend can remain for potential future use, but is no longer used by this endpointLink to Devin run: https://app.devin.ai/sessions/96cc0272ee1649f3bacf73bd022c4c53
Requested by: @Mirajul-Mohin