-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
feat(audio): add flag for Whisper chunking (#19772) #19961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: electricplayer <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @hardikkgupta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new configuration option for Whisper audio transcription, providing finer control over how initial prompts are applied when processing long audio files that are internally chunked. This enhancement addresses a specific user need by allowing the original prompt to be consistently reused across all audio segments, improving transcription continuity for certain use cases.
Highlights
- API Extension for Whisper Transcription: I've added a new boolean field,
reuse_initial_prompt
, to theTranscriptionRequest
model. This field, defaulting toFalse
, allows users to specify whether the initialprompt
string should be appended to every audio chunk during Whisper transcription, or only to the first chunk. - Conditional Prompt Application Logic: I've updated the
_preprocess_transcription
function inserving_transcription.py
to implement the logic for the newreuse_initial_prompt
flag. Now, thedecoder_prompt
for each audio chunk is conditionally constructed: the original prompt is included either for the first chunk only (default behavior) or for all chunks ifreuse_initial_prompt
is set toTrue
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a new boolean field reuse_initial_prompt
to the TranscriptionRequest
to control whether the initial prompt is reused for every audio chunk during transcription. The changes also include modifications to serving_transcription.py
to implement this functionality. The code appears functional, but some minor improvements can be made for readability and conciseness.
# Decide whether to pass the original prompt to this chunk | ||
if i == 0 or request.reuse_initial_prompt: | ||
decoder_prompt = ( | ||
f"<|startoftranscript|>{lang_token}<|transcribe|>" | ||
f"<|notimestamps|>{request.prompt}" | ||
) | ||
else: | ||
decoder_prompt = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic could be simplified by directly assigning the appropriate prompt based on the condition, instead of using an if/else block to assign to decoder_prompt
.
decoder_prompt = (
f"<|startoftranscript|>{lang_token}<|transcribe|>"
f"<|notimestamps|>{request.prompt}"
if i == 0 or request.reuse_initial_prompt
else ""
)
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Add a
reuse_initial_prompt
boolean field toTranscriptionRequest
and plumb it throughserving_transcription.py
.When
true
, the originalprompt
string is appended to every audio chunk; whenfalse
(default) only the first chunk receives it.Fixes #19772.
Test Plan
No automated tests yet. Verified locally by:
reuse_initial_prompt=false
(default) and once withtrue
—and confirming that both calls return transcribed text without errors.