-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
[Perf][CLI] Improve overall startup time #19941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @aarnphm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces significant performance improvements, particularly for the CLI startup time, by implementing a comprehensive lazy loading strategy across the vllm
package and its command-line interface. It also refactors configuration validation and optimizes argument parsing, contributing to a more efficient and responsive user experience.
Highlights
- Core Lazy Loading Implementation: The primary
vllm/__init__.py
file has been refactored to use a__getattr__
mechanism. This defers the import of various vLLM components (likeEngineArgs
,LLMEngine
,SamplingParams
, etc.) until they are actually accessed, significantly reducing initial startup overhead. - CLI Subcommand Lazy Loading: All major CLI subcommands (
benchmark
,collect-env
,openai
,run-batch
,serve
) now lazily load their respective modules and dependencies. Imports previously at the top of these files have been moved into theirmain
orsubparser_init
functions, ensuring they are only loaded when a specific subcommand is invoked. - Configuration Validation Refactoring: The
vllm/config.py
file has been updated to leverage Pydantic'smodel_validator(mode='after')
decorator for argument validation. This removes explicit calls to_verify_args()
in__post_init__
methods, making validation an inherent part of the model's lifecycle and potentially deferring some checks. - Optimized Argument Parsing: The
get_kwargs
function invllm/engine/arg_utils.py
has been optimized withfunctools.lru_cache
to cache computation results and now returns acopy.deepcopy
to prevent unintended modifications of cached data, improving performance for repeated calls. - Cleanup of Eager Imports and Logging: Several unnecessary eager imports have been removed across various files (e.g.,
vllm.triton_utils
fromvllm/utils.py
). Logging initialization has been standardized across CLI entrypoints, and some logging messages have been improved for clarity.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The code changes introduce lazy loading for vllm imports to improve CLI startup time. The changes also include refactoring and improvements to configuration and argument parsing.
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
978b41f
to
e491887
Compare
Signed-off-by: Aaron Pham <[email protected]>
This PR performs lazy loading for importing vllm, where it tries to cleanup a lot of eager heavy imports to help improve general CLI startup experience
This PR does:
vllm/__init__.py
to avoid unwanted side-effect. I have checked that most of these imports will be run during serve/engine initialization@model_validator
hooksarg_utils.py
, given that these are currently being called multiples times (we only need this for CLI, so most of the time, it is safe to have this cache. I used a lru_cache size of 30 preemptively to make sure we have enough room for future configuration if needed)With this PR, it reduces the vllm CLI by around 2 seconds which we still have a lot of room for improvement (a part of #19824 to improve general startup UX)
Here is the hyperfine for
vllm -h
. Python 3.11, 8xH100 instances on LambdaLabs:with this PR
On current main
Signed-off-by: Aaron Pham [email protected]