Skip to content

refactor example - qwen3_reranker #19847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Jun 19, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

  • Move the to main, make the entrypoint clean and keep the same style with the other examples

Test Plan

Test Result

(Optional) Documentation Update

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @reidliu41, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring the qwen3_reranker.py example script to improve its overall structure, readability, and consistency with standard Python practices. The changes involve encapsulating model initialization and main execution logic into functions, making the script's entry point cleaner and more maintainable.

Highlights

  • Code Structure Refinement: I've refactored the qwen3_reranker.py example script to encapsulate the LLM model initialization within a dedicated get_model() function. This promotes better organization and reusability of the model setup.
  • Standard Entry Point Adoption: The main execution logic of the script has been moved into a main() function, and the script now uses the standard if __name__ == "__main__": main() pattern. This improves the script's adherence to common Python best practices and consistency with other examples.
  • Output Formatting: I've added separator lines (---) around the printed score output to enhance readability and make the results clearer when the script is executed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added documentation Improvements or additions to documentation qwen Related to Qwen models labels Jun 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the examples/offline_inference/qwen3_reranker.py script by introducing get_model() and main() functions. This is a positive change that improves the script's structure, making it cleaner and more aligned with common Python practices.

My review focuses on enhancing these new functions by suggesting the addition of docstrings and type hints. These additions would improve code clarity, maintainability, and consistency, which are valuable for example code. My suggestions refer to Python's PEP 257 (Docstring Conventions) and PEP 484 (Type Hints).

Additionally, the PR description checklist is largely unfilled. It would be beneficial for the author to complete it to provide more context about the purpose, testing, and any related documentation updates for this change.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@reidliu41 reidliu41 force-pushed the refactor-qwen3_reranker branch from 724c26b to f69ae35 Compare June 19, 2025 08:59
@noooop
Copy link
Contributor

noooop commented Jun 19, 2025

Please wait for #19675

More usage will be added, hoping they can be considered during refactoring.

@dengcao
Copy link

dengcao commented Jun 20, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation qwen Related to Qwen models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants