-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
refactor example - qwen3_reranker #19847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @reidliu41, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on refactoring the qwen3_reranker.py
example script to improve its overall structure, readability, and consistency with standard Python practices. The changes involve encapsulating model initialization and main execution logic into functions, making the script's entry point cleaner and more maintainable.
Highlights
- Code Structure Refinement: I've refactored the
qwen3_reranker.py
example script to encapsulate theLLM
model initialization within a dedicatedget_model()
function. This promotes better organization and reusability of the model setup. - Standard Entry Point Adoption: The main execution logic of the script has been moved into a
main()
function, and the script now uses the standardif __name__ == "__main__": main()
pattern. This improves the script's adherence to common Python best practices and consistency with other examples. - Output Formatting: I've added separator lines (
---
) around the printed score output to enhance readability and make the results clearer when the script is executed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the examples/offline_inference/qwen3_reranker.py
script by introducing get_model()
and main()
functions. This is a positive change that improves the script's structure, making it cleaner and more aligned with common Python practices.
My review focuses on enhancing these new functions by suggesting the addition of docstrings and type hints. These additions would improve code clarity, maintainability, and consistency, which are valuable for example code. My suggestions refer to Python's PEP 257 (Docstring Conventions) and PEP 484 (Type Hints).
Additionally, the PR description checklist is largely unfilled. It would be beneficial for the author to complete it to provide more context about the purpose, testing, and any related documentation updates for this change.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: reidliu41 <[email protected]>
724c26b
to
f69ae35
Compare
Please wait for #19675 More usage will be added, hoping they can be considered during refactoring. |
You can use Vllm to deploy the Qwen3-Reranker large model.There is already a temporary solution: GitHub: |
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update