Skip to content

Centralizes environment variable access by routing variables reads through the envs.py module #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Centralizes environment variable access by routing variables reads through the envs.py module #1147

wants to merge 5 commits into from

Conversation

@xingliu14
Copy link
Collaborator

@xingliu14 xingliu14 commented Nov 21, 2025 •
edited
Loading

Description

Centralizes environment variable access by routing following environment variable reads through the envs.py module.

  • SKIP_JAX_PRECOMPILE
  • VLLM_XLA_CHECK_RECOMPILATION
  • MODEL_IMPL_TYPE
  • NEW_MODEL_DESIGN
  • PHASED_PROFILING_DIR
  • PYTHON_TRACER_LEVEL
  • USE_MOE_EP_KERNEL
  • NUM_SLICES
  • RAY_USAGE_STATS_ENABLED
  • VLLM_USE_RAY_COMPILED_DAG_CHANNEL_TYPE

Addressing #1016.

Tests

pytest

tests/runner/test_utils.py
tests/worker/tpu_worker_test.py
tests/runner/test_tpu_runner.py
tests/layers/common/test_attention_interface.py
tests/executors/test_ray_distributed_executor.py
tests/runner/test_tpu_runner_mesh.py
tests/test_envs.py

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@xingliu14 xingliu14 marked this pull request as draft November 21, 2025 05:33
@xingliu14 xingliu14 force-pushed the env_var branch 2 times, most recently from 2c3df07 to 29f7940 Compare November 21, 2025 06:43
@xingliu14 xingliu14 marked this pull request as ready for review November 21, 2025 07:08
@xingliu14
Copy link
Collaborator Author

xingliu14 commented Nov 21, 2025

@kyuyeunk It's ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sixiang-google sixiang-google Awaiting requested review from sixiang-google sixiang-google is a code owner

@mrjunwan-lang mrjunwan-lang Awaiting requested review from mrjunwan-lang mrjunwan-lang is a code owner

@py4 py4 Awaiting requested review from py4 py4 is a code owner

@vanbasten23 vanbasten23 Awaiting requested review from vanbasten23 vanbasten23 is a code owner

@wenxindongwork wenxindongwork Awaiting requested review from wenxindongwork wenxindongwork is a code owner

@kyuyeunk kyuyeunk Awaiting requested review from kyuyeunk kyuyeunk is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xingliu14