Skip to content

feat: pass engineLabels to workerGroup #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: pass engineLabels to workerGroup #753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/templates/ray-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ spec:
labels:
model: {{ $modelSpec.name }}
helm-release-name: {{ .Release.Name }}
{{- include "chart.engineLabels" . | nindent 12 }}
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly uses the existing chart.engineLabels helper, this helper has a potential flaw. If .Values.servingEngineSpec.labels is defined as an empty map (e.g., labels: {} in values.yaml), the toYaml function within the helper will render {}. This results in invalid YAML for the pod labels, causing Helm to fail during template rendering.

To make the chart more robust, I recommend improving the chart.engineLabels helper in helm/templates/_helpers.tpl. A safer implementation would be to iterate through the labels, which correctly handles an empty map.

Here is a suggested implementation for the helper:

{{- define "chart.engineLabels" -}}
{{- range $key, $value := .Values.servingEngineSpec.labels }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- end }}

Since this is a pre-existing issue and you are following an established pattern, this is not a blocker for this PR. However, addressing this would be a valuable improvement for the chart's stability.

{{- if .Values.servingEngineSpec.securityContext }}
securityContext:
{{- toYaml .Values.servingEngineSpec.securityContext | nindent 10 }}
Expand Down