Skip to content

[Actorder] Fix GPTQ actorder logic, only apply actorder to weight group args #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2025
Merged

[Actorder] Fix GPTQ actorder logic, only apply actorder to weight group args #1815

merged 4 commits into from
Sep 16, 2025

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented Sep 12, 2025 •
edited
Loading

SUMMARY:

  • Don't set actorder to static if running channel quantization
  • The modifier level actoder value is also getting serialized incorrectly - we set it to None if the strategy is not GROUP but still missing a step to serialize it correctlt when it is None
  • FIx test case which is using an incorrect activation quantization strategy
  • Update compress / decompress test case

Testing

  • Fixes failing tests
  • There is still a bug where Sentinel values are not serialized correctly

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@dsikka dsikka added the ready When a PR is ready for review label Sep 12, 2025
kylesayrs
kylesayrs reviewed Sep 12, 2025
View reviewed changes
@kylesayrs kylesayrs changed the title [Actorder] Update GPTQ actorder logic [Actorder] Fix GPTQ actorder logic, only apply actorder to weight group args Sep 15, 2025
@kylesayrs kylesayrs marked this pull request as ready for review September 15, 2025 16:58
@kylesayrs kylesayrs mentioned this pull request Sep 15, 2025
Merged
@dsikka dsikka enabled auto-merge (squash) September 15, 2025 21:04
rahul-tuli
rahul-tuli approved these changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsikka dsikka disabled auto-merge September 16, 2025 15:49
@dsikka dsikka merged commit b78b052 into main Sep 16, 2025
7 of 8 checks passed
@dsikka dsikka deleted the update_actorder branch September 16, 2025 15:49
dsikka added a commit that referenced this pull request Sep 16, 2025
@kylesayrs @dsikka
[Actorder] Fix GPTQ actorder serialization (#1818)
a7bc45d 
## Purpose ##
* Fix serialization of actorder sentinel values

## Prerequisites ##
* #1815

## Changes ##
* Write explicit serializer for actorder field
* Move down deprecated field checker, since it's less important to read
first

## Testing ##
* Added test which fails without these changes

---------

Signed-off-by: Kyle Sayers <[email protected]>
Co-authored-by: Dipika Sikka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@rahul-tuli rahul-tuli rahul-tuli approved these changes

@kylesayrs kylesayrs Awaiting requested review from kylesayrs

Assignees
No one assigned
Labels
ready When a PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsikka @brian-dellabetta @kylesayrs @rahul-tuli