add custom dict camelize logic #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dalthecow <[email protected]>
|
🎉 Live Preview: Click here to view the live version |
Signed-off-by: dalthecow <[email protected]>
sjmonson
requested changes
Jul 30, 2025
|
|
||
| for key_pair in updated_key_pairs: | ||
| old_key, updated_key = key_pair | ||
| d[updated_key] = d[old_key] |
There was a problem hiding this comment.
Small nit. Might want to throw an exception here in the case that updated_key already exists. Could save a bunch of debugging time later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes reliance on the library pyhumps converting dicts keys from snake_case to camelCase for use in the UI