Minor changes... #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int32_t' (aka 'int')
In Debug Configuration: DEBUG=1 In Release Configuration: NDEBUG=1 NS_BLOCK_ASSERTIONS=1
…arning. Private categories aren't intended to override public declarations -- they are for removing them from headers. Before this commit, the advertisement in the header did not match the implementation. Since the getter and setter should match as far as atomicity and reference counting, another alternative fix is to write different protocols and different (but similar) classes if you have another intended protocol use.
…t this assumes all format strings should be 64-bit since the 32-bit build target is broken at present. This assumption may prove wrong later; though this fork is intended for use with CocosBuilder.
…fined, but __cplusplus is defined.
…efined and __STDC_VERSION__ >= 199901L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream fork chain is long, and asleep.