API Generator: Improve performance by not formatting generated files with ESLint anymore #3789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… eslint anymore When scaffolding run eslint as first step. This switches eslint to TypeScript Compiler Api printer, which is very limited but very fast
…don't generate duplicated imports
nsams
force-pushed
the
api-generator-remove-eslint
branch
from
ac16343 to
1ff9c58
Compare
in demo this close suddenly took 1 minute (did not before). And as we don't open a connection to a real database I don't see any need for a close, especially as the script exits anyway right after the close.
johnnyomair
reviewed
Apr 24, 2025
yes, we could do that - the initial reason why we added them is gone. But: we would loose the diff for the generated code, I'm really not sure what is best. |
Should we invest some effort to fix formatting (e.g., order imports)? |
Imho it is fine like that. Not perfect, but good enough. |
johnnyomair
changed the title
johnnyomair
reviewed
May 12, 2025
packages/api/api-generator/src/commands/generate/utils/write-generated-file.ts
Outdated
Show resolved
Hide resolved
johnnyomair
reviewed
May 12, 2025
packages/api/api-generator/src/commands/generate/utils/__tests__/remove-unused-imports.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Johannes Obermair <[email protected]>
Co-authored-by: Johannes Obermair <[email protected]>
johnnyomair
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches eslint to TypeScript Compiler Api printer, which is very limited but very fast
Runtime in my machine is now 10s for demo
When scaffolding run eslint as first step.