Add singleton capabilities #4
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vitalinfo Please let me know your thoughts? Notice that test coverage is pending, as well as manual testing. I just want to run the concept (see PR description above) by you guys before proceeding any further. |
jolim
reviewed
Jun 1, 2024
vitalinfo
reviewed
Jun 3, 2024
| @flusher_lock_ttl = flusher_lock_ttl | ||
| end | ||
|
|
||
| def lock_singleton_flusher |
| end | ||
|
|
||
| def lock_singleton_flusher | ||
| raise "Singleton flusher lock for '#{flusher_key}' already exists" if singleton_flusher_locked? |
| class SingletonFlusher < SingletonBase | ||
| attr_reader :flusher_lock_ttl | ||
|
|
||
| def initialize(queue, worker_class, flusher_lock_ttl: 5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the worker passes the
singleton_worker: trueoption, flush will not happen if there is a worker of this class/queue already running.The worker is expected to include
Sidekiq::Grouping::SingletonWorkerConcernand usewith_singleton_worker_lockto wrap the critical operations it wants to prevent concurrency issues for.By not launching another worker while there is already one running, we achieve 2 goals: