Add XRExperience to babylon.js #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename "DomainMgr" to "DomainManager" for clarity. - Convert DomainManager from an object literal to a static class for clarity. - Remove unused functions, methods, types, and variables. - Use `private` syntax instead of `#_` for clarity and consistency. - Add TSDoc comments to all necessary class members. - Expand and clarify all method and variable names. For example: `pD` to `domain`, and `avaMixer` to `avatarMixer`. - Clarify all log messages. - Make unused promises synchronous.
- Rename "MetaverseMgr" to "MetaverseManager" for clarity. - Convert MetaverseManager from an object literal to a static class for clarity. - Remove unused functions, methods, types, and variables. - Use `private` syntax instead of `#_` for clarity and consistency. - Add TSDoc comments to all necessary class members.
- Convert AudioIO to a static class. - Use `private` syntax instead of `$` for clarity. - Add TSDoc comments to all necessary class members. - Remove unused methods. - Create AudioLevel UI component to simplify displaying the mic input level.
- Convert AvatarStoreInterface from an object literal to a static class for clarity. - Add TSDoc comments to all class members. - Rename "AvatarEntry" and "AvatarEntryMap" interfaces to "AvatarModel" and "AvatarModelMap" for clarity.
- Add TSDoc comments to all necessary component methods.
- Remove unused component methods.
- Clarify method names.
- Simplify component logic.
- Ensure consistent formatting:
- Style-Template-Script for all components.
- `return {};` syntax for data and setup options to ensure consistent handling of `this`.
- One blank line between all component options for clarity.
- Convert Utility from an object literal to a static class for clarity. - Clarify variable and method names. - Add TSDoc comments to all methods.
- Rename "AudioMgr" to "AudioManager" for clarity. - Convert AudioManager from an object literal to a static class for clarity. - Remove unused methods and variables. - Clarify variable and method names. - Add TSDoc comments to various methods.
- Convert Places from an object literal to a static class for clarity. - Add TSDoc comments.
- Fix incorrect global component name. - Correct broken import of `AudioMgr` to `AudioManager`. - Fix incorrect active Domain assignment.
- Fix typos and grammar. - Add TSDoc comments to various classes and methods. - Remove useless getters/setters. - Use explicit type imports.
My bad, I forgot this was part of our coding standard.
Remove calls to the DefaultRenderingPipeline from VScene, since that pipeline is already managed by the ZoneEntityController.
…t light intensity
Co-authored-by: David Rowe <[email protected]> Signed-off-by: Giga <[email protected]>
Co-authored-by: David Rowe <[email protected]> Signed-off-by: Giga <[email protected]>
Tidy and document the codebase.
Fix collisions due to bad mapping of shape types.
…a World SDK. (#223) * Update vircadia-world * Minor improvements [pre-overhaul] * Update vircadia-world-sdk structure. * Remove Igloo experimental support. * Bump vers number, also bump all packages (major). * Fix keyword import, comment out Vircadia World init for now. * Improve styling for light/dark modes. * Improve log styling. * Fix color issues with console. (color not working yet)
* Bump packages; add other packages; update paths for SDK. * Update paths and include paths. * Mild refactor; begin adding Script functionality. * Scripting works now. * Make skybox not pickable. * Fix scripting timing. * Bump Babylon to 7.27.0 * Remove unused code. * Fix desktop build. * Bump node vers for desktop build 16 -> 20 * WIP * Revert "WIP" This reverts commit 7b218d6. * Update how avatars are handled.
* unparent skybox from zone Skybox is no longer attached to zone and now displays behind everything else as "infinite." This is one step towards allowing for multiple zones to work properly. * Fixed a repeated typo across multiple files - changed entity.copyFormPacketData(props) to entity.copyFromPacketData(props) in multiple files - changed `"Receive entity data:`, data)" to "Receive entity data:", data.length.toString())" * Add compound shape url handling to zone entity. * Added initial mesh to Zones - each zone now has a child mesh matching dimensions. Used "shapeType" so that we can change the mesh later for custom shapes. * Set skybox to a fixed distance of 10000 -skybox set to 10000 instead of pulling the zone dimensions * redirected sara.glb to local file -we were loading this file from a server rather than from the local copy (which was already in the assets folder). * Zone now detects when MainCamera is within it's bounds -detections for when a camera exists or enters a zone. * Fixed "undefined" ZoneEntityController name ZoneEntityController will now get it's suffix and ID from it's parent Zone * Add timer to Zone check - Instead of checking which zone we are in every frame, I've set the timer to every 200ms for the time being. * Fixed small bugs to reduce start warnings -minor bugfixes -some defined but unused elements commented out with TODO * Reverting changes -pushed at the wrong stage. Whoopsie. * Initial support for multiple zones added -you can now have multiple zones that will switch skybox backgrounds and settings depending on which zone's bounding box/shape the camera within at the time. * Zone Properties & Skybox Sync -Switching of Zone Properties and the display of skyboxes are now on the same timer found in ZoneManager.ts * -foundation for compound mesh shaped zones -This lays the foundation for being able to use a glb file as your zone shape. * Custom compound mesh for zones now working -you can now enter a compound URL (glb) and use this to control the shape of your zone. * Added option to disable bevels and regain 15-20 fps -created "const enableBevels" Bool and set default to "false" for the time being. * Added the option to enable or disable alpha effects on nametags/labels added new "const enableAlpha " property and switched off transparency effects on labels as default. * Attempt to fix macOS build. --------- Co-authored-by: Aitolda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to implement webXR in vscene.ts. It is working, but I didn't figure out how to parent the instantiated XR camera to the existing non XR camera. I've added controllers support, but we need to add actions for each button. In this version the controllers are not parented to the avatar hands in first person view like it should be. I've tested on Quest browser and it is loading fine.
vscene.ts.txt