Native client library audio mixer APIs. #1675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no member functions are used, and the two calls construct a transform object in place.
replaced by a simpler structure and a function.
by moving the script value conversion functions into AudioScriptingInterface.
by separating the codec interface from the plugin interface.
for future use in client library. The respective plugins are now just
wrappers for these.
…ion, based on audio-client library with interface specific parts removed.
|
The following links are available: build (macOS-10.15, full) build (ubuntu-18.04, full)
build (windows-2019, full) build (self-hosted_debian-11_aarch64, full)
|
as it's the only dependency from QtMultimedia.
…into the audio thread.
reference held somewhere.
until a valid input was set by the user.
it gives both default getter lambdas the same mangled name, likely https://bugs.llvm.org/show_bug.cgi?id=33924, XCode 11.2
digisomni
requested review from
a team and
ctrlaltdavid
and removed request for
ctrlaltdavid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aims to resolve #1643
As with avatar APIs the refactoring is partial, there is a new library consisting of parts of
audio-clientthat were not interface specific, but it's not yet used inaudio-clientlibrary itself, leaving that for later again in favor of quicker Unity SDK features.There are conflicts between this and #1582, since I have separated codecs from plugins as part of refactoring.