Fix for DCF value #174
Open
Fix for DCF value #174
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case net cash flow is not available, mark it as 0 but keep the signal neutral
Proof check intrinsic_value
duke-cliff
approved these changes
Mar 26, 2025
virattt
reviewed
Mar 26, 2025
| @@ -87,6 +87,10 @@ def valuation_agent(state: AgentState): | |||
| # Get the market cap | |||
| market_cap = get_market_cap(ticker=ticker, end_date=end_date) | |||
|
|
|||
| # Reset dcf value to market value if dcf_value = 0 | |||
| if dcf_value == 0: | |||
| dcf_value = market_cap | |||
There was a problem hiding this comment.
Why would we set the DCF value to the market cap?
There was a problem hiding this comment.
I found there are cases the API cannot provide free cashflow records at all. So this is a fallback by just setting dcf value to market cap, and it will make sure the valuation is neutral rather than 100% cap gap.
The idea is dcf is already a useless indicator if dcf value is 0. Better just neutralize it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.