This repository was archived by the owner on Mar 14, 2021. It is now read-only.
improves #12
Open
improves #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinicius73
commented
Oct 30, 2018
vinicius73
commented
- use v-model
- loading feedback
- use mapActions
- use computed: hasContributors
…: hasContributors
Owner
|
@vinicius73 obrigado por submeter o PR. Podes apenas remover o |
Owner
|
Outro ponto, se quiser te adicionar no contributors do |
viniciuskneves
suggested changes
Oct 31, 2018
Owner
viniciuskneves
left a comment
viniciuskneves
left a comment
There was a problem hiding this comment.
Tests are broken now and there are tests missing for those new implementations. Please fix it before we move forward!
Owner
|
@vinicius73 how about tests? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.