Remote function #359
Merged
Remote function #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to use SvelteKit's new remote functions and top-level await features, replacing the traditional server-side data loading approach with a more streamlined component-based data fetching pattern.
- Enables experimental async support and remote functions in SvelteKit configuration
- Converts server-side tweet fetching to a remote function with client-side component loading
- Upgrades SvelteKit and Svelte to versions that support these new features
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| svelte.config.js | Enables experimental async and remote functions features |
| src/routes/ListenersTweets.svelte | Refactors to use individual Tweet components instead of server-provided data |
| src/routes/+page.svelte | Removes dependency on server-side data loading |
| src/routes/+page.server.ts | Removes server-side data loading logic (deleted) |
| src/lib/Tweet/index.ts | Exports new Tweet component |
| src/lib/Tweet/getTweet.remote.ts | Implements remote function for tweet fetching with validation |
| src/lib/Tweet/Tweet.svelte | Creates component that uses remote function with top-level await |
| package.json | Updates SvelteKit, Svelte versions and adds valibot dependency |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Deploying vim-jp-radio-lp with
|
| Latest commit: |
c4933da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6da997fc.lp-d1f.pages.dev |
| Branch Preview URL: | https://remote.lp-d1f.pages.dev |
ryoppippi
commented
Aug 1, 2025
src/lib/Tweet/Tweet.svelte
Outdated
| const { id }: Props = $props(); | ||
| </script> | ||
|
|
||
| <svelte:boundary> |
There was a problem hiding this comment.
https://svelte.dev/docs/svelte/await-expressions#Boundaries
boundaryで囲ってあげる必要がある
There was a problem hiding this comment.
boundaryを使う方法はprerenderだと動かないっぽい
Svelte does not yet support asynchronous server-side rendering, and as such it’s likely that you’re only calling remote functions from the browser, rather than during prerendering. Because of this you will need to use inputs, for now. We’re actively working on this roadblock.
ryoppippi
commented
Aug 1, 2025
|
あれ、リスナーの声が表示されてない |
|
だめじゃんあれ |
…hronous server-side rendering
|
直った！マージします |
|
結局top-level-awaitは使わなかった |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sveltekitのremote functionとtop-level-awaitが生えたので反映
めっちゃみやすくなったと思う
https://svelte.dev/docs/kit/remote-functions
https://svelte.dev/docs/svelte/await-expressions