Use static hashCode() methods #353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 8 added static hashCode() methods like Double.hashCode(double). https://docs.oracle.com/javase/8/docs/api/java/lang/Double.html#hashCode-double- These are equivalent to what HashCommon.double2int(double) claims to do https://javadoc.io/doc/it.unimi.dsi/fastutil/latest/it/unimi/dsi/fastutil/HashCommon.html#double2int(double) but double2int() uses Double.doubleToRawLongBits(), whereas Double.HashCode() uses Double.doubleToLongBits(). Therefore, also update KEY2INTHASH() and KEY2LONGHASH() to use doubleToLongBits(). Since HashCommon is a public class, I didn't delete the old HashCommon.double2int(), float2int(), and long2int() functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 8 added static hashCode() methods like Double.hashCode(double).
https://docs.oracle.com/javase/8/docs/api/java/lang/Double.html#hashCode-double-
These are equivalent to what HashCommon.double2int(double) claims to do
https://javadoc.io/doc/it.unimi.dsi/fastutil/latest/it/unimi/dsi/fastutil/HashCommon.html#double2int(double)
but double2int() uses Double.doubleToRawLongBits(), whereas Double.HashCode() uses Double.doubleToLongBits(). Therefore, also update KEY2INTHASH() and KEY2LONGHASH() to use doubleToLongBits().
Since HashCommon is a public class, I didn't delete the old HashCommon.double2int(), float2int(), and long2int() functions.