Skip to content

Conversation

DTCurrie
Copy link
Member

@DTCurrie DTCurrie commented Aug 28, 2025

Relies on this ts-sdk PR and the two projects being in the same parent directory. WIP just something for us to start e2e testing with. Adds the ability to interact with streaming queries, WIP there are some typing issues just getting this setup to start e2e testing.

@DTCurrie DTCurrie requested a review from micheal-parks August 28, 2025 18:29
@DTCurrie DTCurrie self-assigned this Aug 28, 2025
Copy link

changeset-bot bot commented Aug 28, 2025

🦋 Changeset detected

Latest commit: 6724887

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viamrobotics/svelte-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@micheal-parks micheal-parks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the changeset!

@DTCurrie
Copy link
Member Author

Don't forget the changeset!

I don't think this is quite ready to merge. I think my types are still a bit off but putting up everything for you to check out.

@micheal-parks
Copy link
Member

Which types aren't working as expected? From a read through it looks correct

@DTCurrie
Copy link
Member Author

DTCurrie commented Sep 3, 2025

Which types aren't working as expected? From a read through it looks correct

It was about determining the type of the value returned from the AsyncGenerator iterator. I managed to figure it out.

@DTCurrie
Copy link
Member Author

DTCurrie commented Sep 3, 2025

I am not adding docs to the readme for this hook because it relies on an experimental tanstack feature. Let's see how things go before we document it.

@DTCurrie DTCurrie merged commit bb76112 into main Sep 3, 2025
4 checks passed
@DTCurrie DTCurrie deleted the add-resource-stream-hook branch September 3, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants